Skip to content

[PWGCF/EbyE] Fixing process() and all the linters #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
baasingh wants to merge 5 commits into from
Closed

[PWGCF/EbyE] Fixing process() and all the linters #14428

baasingh wants to merge 5 commits into from
+154 −54

Conversation

@baasingh
Copy link
Contributor

@baasingh baasingh commented Jan 8, 2026

  • Subscribe required table in the process function,
  • To fix linters code name need to change.
  • Fix all the linters which were not done in the previous: https://github.com/AliceO2Group/O2Physics/pull/14042

@github-actions github-actions bot added the pwgcf label Jan 8, 2026
@github-actions github-actions bot changed the title PWGCF/EbyE: Fixing process() and all the linters [PWGCF/EbyE] Fixing process() and all the linters Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@vkucera vkucera marked this pull request as draft January 9, 2026 06:45
@vkucera
Copy link
Collaborator

vkucera commented Jan 9, 2026

@baasingh Don't open your PR as ready for review if it doesn't pass required checks.

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

Why did you give the file a wrong name in 47c6de8?

@baasingh
Copy link
Contributor Author

baasingh commented Jan 12, 2026

Hi @vkucera, thank you so much for the reply.
I was trying to fix all the linter issues, one of which was the code name, so II did this PR:
33a4c66
but it gave errors for other workflow names.

Now, i tried to revert back in this: 47c6de8

I am not able to comprehend the issue.

Thanks,
Balwan

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026 •
edited
Loading

Which remaining issues are you trying to fix exactly?

@baasingh
Copy link
Contributor Author

baasingh commented Jan 12, 2026

I was asked in my previous PR to fix the linter issues (https://github.com/AliceO2Group/O2Physics/pull/14042#pullrequestreview-3580503130)

Now, there is one left linter issue,
when I run the command:
python3 Scripts/o2_linter.py PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx
i get: PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:1: warning: Use lowerCamelCase or UpperCamelCase for names of C++ files. See the O2 naming conventions for details. [name/file-cpp]

Results for failed, tolerated and disabled tests

@vkucera
Copy link
Collaborator

vkucera commented Jan 12, 2026

But that's the one you just introduced with your last commit.

@baasingh
Copy link
Contributor Author

baasingh commented Jan 14, 2026

But that's the one you just introduced with your last commit.

Thank you for your help.

Just to clarify, I was trying to resolve the linter error related to the file name. I attempted changing it to lowercase, which is why I was encountering this issue.

Thanks again for your guidance.

@baasingh baasingh marked this pull request as ready for review January 15, 2026 05:35
@baasingh baasingh closed this Jan 15, 2026
@baasingh
Copy link
Contributor Author

baasingh commented Jan 15, 2026

i am closing this PR and will open new one after rebasing my branch.

@baasingh baasingh mentioned this pull request Jan 15, 2026
Merged
@vkucera
Copy link
Collaborator

vkucera commented Jan 15, 2026

i am closing this PR and will open new one after rebasing my branch.

Opening a new PR is completely useless and counterproductive. There is no reason why you could not update the same PR.

@baasingh
Copy link
Contributor Author

baasingh commented Jan 15, 2026

i am closing this PR and will open new one after rebasing my branch.

Opening a new PR is completely useless and counterproductive. There is no reason why you could not update the same PR.

Hi, thank you for the message. I will take care in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baasingh @vkucera